Provision iterator syntax sugar in python #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivaprasad2000
force-pushed
the
iterators
branch
from
bc88fea
to
19b2932
Compare
sivaprasad2000
force-pushed
the
iterators
branch
from
19b2932
to
ef60531
Compare
jerinphilip
changed the title
jerinphilip
approved these changes
Dec 16, 2023
.gitattributes
Outdated
| # Executables | ||
| *.exe binary | ||
| *.out binary | ||
| *.app binary |
Comment on lines
12
to
13
| sen_iter_tgt = iterators.sentences(target) | ||
| word_iter_global = iterators.words(target) |
There was a problem hiding this comment.
We do not prefer abbreviations when it can be named better.
sentences = iterators.sentences(response.target)
for sentence in sentences:
# ...
words = iterators.words(response.target)
for word in words:
# ...In general chaining more entities into the naming connected by _ points to that we've failed somewhere at abstracting (Imagine sentence, sentence_item - instead of sentence, word for an example).
Comment on lines
20
to
39
| expected_text_range = target.word_as_range(sentence_idx, word_idx) | ||
| reconstructed_text_range = word.range() | ||
|
|
||
| # For Sentence Iterator and Word Iterator | ||
| assert expected_text_range.begin == reconstructed_text_range.begin | ||
| assert expected_text_range.end == reconstructed_text_range.end | ||
|
|
||
| expected_word = text[expected_text_range.begin:expected_text_range.end] | ||
| reconstructed_word = word.surface() | ||
|
|
||
| assert expected_word == reconstructed_word | ||
|
|
||
| word_global = next(word_iter_global) | ||
|
|
||
| reconstructed_text_range_glob = word_global.range() | ||
| reconstructed_word_glob = word_global.surface() | ||
|
|
||
| # For Global Word Iterator | ||
| assert expected_text_range.begin == reconstructed_text_range_glob.begin | ||
| assert expected_text_range.end == reconstructed_text_range_glob.end |
There was a problem hiding this comment.
Lot of _ chaining. This is a naming nit, but there's room for improvement. Same intentions/ideas as #40 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes enhances the project a flexible and reusable iterator system for processing annotations in Python, along with associated tests.
.gitattributes:Added a new file with various attributes for Git, specifying binary handling for certain file types.
bindings/python/iterators.py:Added a new Python module (iterators.py) that defines iterators for processing annotations, sentences, and words.
Includes WordIterator and SentenceIterator classes.
Provides
sentences()andwords()for syntax sugar.bindings/python/tests/test_iterators.py:Added a new test module (
test_iterators.py) to test the functionality of the iterators in theiterators.pymodule.slimt/CMakeLists.txt:Modified the CMakeLists.txt file to include changes related to target link libraries and include directories.